Remove Vec::remove_item as discussed in #40062#71834
Closed
LukasKalbertodt wants to merge 1 commit intorust-lang:masterfrom
Closed
Remove Vec::remove_item as discussed in #40062#71834LukasKalbertodt wants to merge 1 commit intorust-lang:masterfrom
Vec::remove_item as discussed in #40062#71834LukasKalbertodt wants to merge 1 commit intorust-lang:masterfrom
Conversation
LukasKalbertodt
commented
May 3, 2020
Member
|
I think we should indeed deprecate and wait for some time (maybe a cycle or so) before removing entirely. |
Mark-Simulacrum
added
the
S-waiting-on-author
joelpalmer
added
S-waiting-on-author
Member
|
@kornelski would you be able to take over this PR? Lukas has been busy recently and I saw that you pursued this in #71979. |
Contributor
|
OK |
Elinvynia
added
S-waiting-on-author
Contributor
Author
|
I haven't seen any activity here, so I just went ahead and opened #73539. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 20, 2020
…e-item, r=Mark-Simulacrum Deprecate `Vec::remove_item` In rust-lang#40062 we decided to remove that method. In rust-lang#71834 it was said that we want to deprecate it for a few cycles before removing it. That's what this PR does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue. I'm not quite sure if we want a transition period where we just deprecated the method without removing.